-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Python 2.6 and 3.3 before removal #175
Conversation
Given folks can lock to a previous release, is deprecation necessary? |
See #166 (comment):
|
I'm pretty sure that it would not, since folks downstream with well-designed requirements files / setup.py / whatever they use to express dependencies will have already locked their builds to a specific major or major.minor of jmespath which would keep them compatible with python 2.6 until they can move forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting this process!
…ation process in docs before starting to deprecate
Codecov Report
@@ Coverage Diff @@
## develop #175 +/- ##
==========================================
+ Coverage 98.19% 98.2% +<.01%
==========================================
Files 14 14
Lines 1441 1446 +5
==========================================
+ Hits 1415 1420 +5
Misses 26 26
Continue to review full report at Codecov.
|
Updated to resolve conflicts! I'd suggest moving forward with this process, as you can see Python 2.6 and 3.3 are not available on Travis CI: $ curl -sSf -o python-2.6.tar.bz2 ${archive_url}
curl: (22) The requested URL returned error: 404 Not Found
Unable to download 2.6 archive. The archive may not exist. Please consider a different version. $ curl -sSf -o python-3.3.tar.bz2 ${archive_url}
curl: (22) The requested URL returned error: 404 Not Found
Unable to download 3.3 archive. The archive may not exist. Please consider a different version. https://travis-ci.org/jmespath/jmespath.py/builds/569774974 Also, Python 3.4 is also now EOL and no longer receiving security updates (or any updates) from the core Python team.
I suggest deprecating/removing that as well. |
Wow, Python 2.6 has reached its EOL in October, 2013. More then six years ago! I hope that all folks who uses it are already well prepared. I think that it (at least 2.6) can be dropped even without deprecation warning. |
I know it's been a while, but I want to follow up on this. Here's my plan. I think it's fine to move fairly quickly on deprecating 2.6/3.3, especially given some of the largest downstream dependencies have dropped 2.6/3.3 recently. Initially I was surprised at the large number of 2.6 downloads, but in looking into it more, it seems to closely match the 2.6 numbers of the aws-cli/botocore which has already dropped 26/33 support.
So here's my plan:
Let me know if there's any questions/concerns. |
Merged via #195 |
It's a good idea to deprecate before removal (#166), to give downstream dependencies a heads up.
How would you like to deprecate?
Here's some ideas. Let me know if you want any of them removing or changing. I assumed JMESPath 1.0 would be the version they'll be dropped in, but that of course can be changed.
Warn when importing
Warn when installing
Document in CHANGELOG
Also added
python_requires
for the current versions (2.6+, 3.3+). This would be useful whatever is decided.