Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6 New Party Parrots #58

Merged
merged 6 commits into from
Dec 1, 2016
Merged

6 New Party Parrots #58

merged 6 commits into from
Dec 1, 2016

Conversation

kbvincent
Copy link
Contributor

@kbvincent kbvincent commented Dec 1, 2016

blondesassyparrot
bluecluesparrot
darkbeerparrot
magaritaparrot
oriolesparrot

and the infamous:
gentlemenparrot

@kbvincent kbvincent changed the title Adding first collection of party parrots I created 6 New Party Parrots Dec 1, 2016
Copy link
Owner

@jmhobbs jmhobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gentleman Parrot 💯

},
{
"gif": "oriolesparrot",
"name": "This parrot loves the orioles so much he turned into one!"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Names should be relatively short, so "Orioles Parrot" or "Gentleman Parrot". Can you rework these to use "tip" for the longer descriptions, which puts a little tooltip popup on the website?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

},
{
"gif": "bluecluesparrot",
"name": "Steve from Blue's Clues Parrot"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some meme with Steve I don't know about, or do you just enjoy Blues Clues? 😄

Copy link
Contributor Author

@kbvincent kbvincent Dec 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, we have a guy on our team that we constantly joke looks like steve from blues clues, so he got his own parrot.

@lucymhdavies
Copy link
Contributor

lucymhdavies commented Dec 1, 2016

s/gentlemenparrot/gentlemanparrot/ ?

He is but one gentleman

@jmhobbs jmhobbs merged commit 537315e into jmhobbs:master Dec 1, 2016
@jmhobbs
Copy link
Owner

jmhobbs commented Dec 1, 2016

@kbvincent kbvincent mentioned this pull request Dec 1, 2016
<li><img src="parrots/blondesassyparrot.gif" alt="Blonde Sassy Parrot"/> Blonde Sassy Parrot</li>
<li><img src="parrots/bluecluesparrot.gif" alt="Blues Clues Parrot"/> Blues Clues Parrot</li>
<li><img src="parrots/gentlemanparrot.gif" alt="Gentleman Parrot"/> Gentleman Parrot</li>
<li><img src="parrots/magaritaparrot.gif" alt="Magarita Parrot"/> Magarita Parrot</li>
Copy link
Contributor

@marcthayer marcthayer Jan 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone fix the spelling of margarita? This repo won't let me push a branch in order to create a pull request to do so. Will hopefully be fixed in #77.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants