Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'filtered:add' event is triggered before the collection is filtered #31

Open
mishamaliga opened this issue Mar 12, 2015 · 1 comment
Open

Comments

@mishamaliga
Copy link

The filtered:add event is triggered in addFilter method, but addFilter method is executed before execFilter.

filterBy: function (filterName, filter) {
    if (!filter) {
        filter = filterName;
        filterName = this.defaultFilterName;
    }
    addFilter.call(this, filterName, createFilter(filter));
    execFilter.call(this);
    return this;
},

I think that filtered:add should be triggered when the collection is already filtered.

@mariuszdev
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants