-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #257 delete amenity cases error 500 #258
Issue #257 delete amenity cases error 500 #258
Conversation
5332ced
to
2fbb1bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
============================================
- Coverage 71.88% 71.23% -0.66%
- Complexity 223 224 +1
============================================
Files 36 37 +1
Lines 939 949 +10
Branches 42 45 +3
============================================
+ Hits 675 676 +1
- Misses 256 264 +8
- Partials 8 9 +1
Continue to review full report at Codecov.
|
Could you rename the PR name and resolve conflicts @DDmit04 ? |
8bf6f14
to
1a05d7c
Compare
service/src/main/java/com/myhome/controllers/CommunityController.java
Outdated
Show resolved
Hide resolved
service/src/main/java/com/myhome/controllers/CommunityController.java
Outdated
Show resolved
Hide resolved
service/src/main/java/com/myhome/controllers/CommunityController.java
Outdated
Show resolved
Hide resolved
service/src/main/java/com/myhome/controllers/CommunityController.java
Outdated
Show resolved
Hide resolved
service/src/test/java/com/myhome/services/unit/AmenityBookingSDJpaServiceTest.java
Show resolved
Hide resolved
service/src/test/java/com/myhome/services/unit/AmenityBookingSDJpaServiceTest.java
Outdated
Show resolved
Hide resolved
service/src/test/java/com/myhome/services/unit/AmenityBookingSDJpaServiceTest.java
Outdated
Show resolved
Hide resolved
service/src/test/java/com/myhome/services/unit/CommunitySDJpaServiceTest.java
Outdated
Show resolved
Hide resolved
service/src/test/java/com/myhome/services/unit/CommunitySDJpaServiceTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash changes beetween 603ad2a86f11a90f86dea1680775b6fdd97fd2a4
and 1c76c92b81ff1b2549b24b20d2c3d685c7ab1581
because the history of codebase is modified by this adding and deleting fields but it should not...
It is related to problematic rebase/merge with master on your side
938b66f
to
b73fbf1
Compare
service/src/test/java/com/myhome/services/unit/AmenityBookingSDJpaServiceTest.java
Outdated
Show resolved
Hide resolved
(cherry picked from commit a573a07)
@mslowiak This can be merged? |
🚀 Description
fix 500 error on delete amenity
Closes: #257
📦 Types of changes