-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture duration of stay for each house member #46
Comments
|
|
@jmprathab Can I pick this task? |
Whats the status now? Is it fixed?Can I try that out. I am a beginner though. |
@VinitaNirmal Can you please update the status? |
@jmprathab I have completed the code and raised the PR. I have made the changes according to the reviews done by you too. |
@VinitaNirmal |
Reopen because of no feedback from developer |
Hello, I can take this. Can you assign it to me? |
@Giluerre Sure. |
@Giluerre |
I still need to finish controller and test it. |
@Giluerre |
Well... after updating my branch I noticed controller is now uses openAPI generated interface. So I have started migrating + my return type in old method was entity. |
@jmprathab Can I take a shot at this ? |
@jmprathab A gentle reminder... |
@kev711 |
I have a question regarding this. If the newly created |
@kev711 I guess the best option would be to store four types of dates:
What are your thoughts about the solution above? :) |
Generally, requirement for capturing any data element should come from a business need. Off the bat, I think together with date, time should also be captured. Maybe capture date and time together as an Unix Epoch time. Do you see any issues with that ? |
|
According to your previous question - yes, we should get dates from users as |
Hi @mslowiak, |
@mslowiak @jmprathab Hey, I'm a university student and we have this class in this semester where the main goal of the class is to contribute code to an open source project. I find this project to be really interesting and would like to contribute. I see no one worked on this issue for quite some time and it seems like something I would like to try to solve. If it's possible please assign me this issue. Thank you. |
Ability to add the duration of stay for each house member. Users should be able to set From date and To date during which a member stayed in the house.
Endpoints
GET /houses/{houseId}/rentals
- Which returns a list of members and their time range of stay. End time is empty for currently staying memberPOST /houses/{houseId}/rentals
- Create a new rental for a house member. Get the start date and end date in request body.The text was updated successfully, but these errors were encountered: