Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta 0.9.8 (Linux): Flicker when opening hamburger menu #801

Closed
DSeeLP opened this issue Jun 29, 2024 · 5 comments
Closed

Beta 0.9.8 (Linux): Flicker when opening hamburger menu #801

DSeeLP opened this issue Jun 29, 2024 · 5 comments
Labels
awaiting response / stale Issue is possibly outdated or waiting for user feedback bug Something isn't working desktop Desktop-specific issues redesign-beta Issues related to the beta/redsigned version of Finamp upstream issue Issue requires changes to an upstream project (Flutter framework, used package/plugin)

Comments

@DSeeLP
Copy link

DSeeLP commented Jun 29, 2024

It flickers when opening the hamburger menu when the miniplayer is there. The flicker doesn't occur when in splitscreen mode.
It only appears when running the app in release mode.

flicker.mp4

I am currently trying to package the beta for NixOS.
I tested this on NixOS with my package and the repo inside a devshell to provide the necessary libraries.
It also happens with the provided binaries on Ubuntu 24.04.

@Chaphasilor
Copy link
Collaborator

Hi, that's a known issue with Flutter itself (https://github.com/flutter/flutter/issue/146807) and has already been fixed upstream (flutter/engine#53103).
So it should be fixed in an upcoming Flutter version :)

@Chaphasilor
Copy link
Collaborator

Btw, there's already an m4 desktop file here in the repo, but it seems like you're creating one from scratch during build. Is there a reason for that?
I'd like to keep things (names, descriptions, etc.) as consistent as possible by reusing metadata across platforms if possible.

@DSeeLP
Copy link
Author

DSeeLP commented Jun 30, 2024

I didn't want to introduce a dependency on m4 and most packages don't have their install path hardcoded in the desktop file as it is expected that upon installation the programs would be in PATH.

@Chaphasilor
Copy link
Collaborator

Have you recently tried building it with a newer Flutter version? It might be fixed by now :)

@Chaphasilor Chaphasilor added bug Something isn't working awaiting response / stale Issue is possibly outdated or waiting for user feedback desktop Desktop-specific issues redesign-beta Issues related to the beta/redsigned version of Finamp upstream issue Issue requires changes to an upstream project (Flutter framework, used package/plugin) labels Jul 29, 2024
@DSeeLP
Copy link
Author

DSeeLP commented Aug 1, 2024

I tried it with the latest version and it doesn't flicker anymore :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response / stale Issue is possibly outdated or waiting for user feedback bug Something isn't working desktop Desktop-specific issues redesign-beta Issues related to the beta/redsigned version of Finamp upstream issue Issue requires changes to an upstream project (Flutter framework, used package/plugin)
Projects
None yet
Development

No branches or pull requests

2 participants