Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest ember depreciations with helpers #18

Closed
Kilowhisky opened this issue Aug 4, 2015 · 14 comments
Closed

Latest ember depreciations with helpers #18

Kilowhisky opened this issue Aug 4, 2015 · 14 comments

Comments

@Kilowhisky
Copy link

FYI latest version of ember yet again screwed with things.

https://github.com/emberjs/ember.js/releases/tag/v1.13.6

DEPRECATION: Using Ember.HTMLBars._registerHelper is deprecated. Helpers (even dashless ones) are automatically resolved. [deprecation id: ember-htmlbars.register-helper]

DEPRECATION: UsingEmber.HTMLBars.makeBoundHelperis deprecated. Please refactor to usingEmber.HelperorEmber.Helper.helper. [deprecation id: ember-htmlbars.make-bound-helper]

@rwjblue
Copy link
Collaborator

rwjblue commented Aug 4, 2015

@Kilowhisky - Yep, we are on it. PR swapping to Ember.Helper based helpers is in #12, but there is a little bit of refactoring to do to fix the test suite here. I'm hopefully going to get this done tonight, but not 100% sure...

@jmurphyau
Copy link
Owner

@rwjblue PR #19 should help with the test refactor you mention - I assume this is the work you're talking about here?

@rwjblue
Copy link
Collaborator

rwjblue commented Aug 10, 2015

@jmurphyau - Yep. #12 will solve this (and #19 is required to allow #12 to pass the test suite).

@jmurphyau
Copy link
Owner

@Kilowhisky check out version 1.1.0 - should resolve the deprecation warnings

@mike-post
Copy link

Confirmed, 1.1.0 solves all the deprecation notices. Thanks!

@rwjblue
Copy link
Collaborator

rwjblue commented Aug 10, 2015

Awesome, thanks for confirming!

@fadeojo
Copy link

fadeojo commented Aug 13, 2015

@rwjblue Ember 1.3.18 still complains Using Ember.HTMLBars._registerHelper is deprecated. Helpers (even dashless ones) are automatically resolved

@fadeojo
Copy link

fadeojo commented Aug 13, 2015

the deprecated code is found in addon/utils/register-helper.js line 16 and 26.

@mike-post
Copy link

@fadeojo Did you upgrade ember-truth-helpers to 1.1.0?

@rwjblue
Copy link
Collaborator

rwjblue commented Aug 14, 2015

Ember Data 1.13.8 also had an issue when published, and accidentally contained deprecated register helper calls. Make sure you have 1.13.9 of Ember data.

@fadeojo
Copy link

fadeojo commented Aug 14, 2015

@mike-post @rwjblue Thanks. It was ember data with the issue. It's all fixed now.

@Arkham
Copy link

Arkham commented Aug 24, 2015

Also make sure to have the latest version of ember-resolver (0.1.19) in your bower.json

@elwayman02
Copy link
Contributor

@rwjblue @jmurphyau @Kilowhisky can this be closed?

@rwjblue
Copy link
Collaborator

rwjblue commented Sep 24, 2015

Ya, I believe so. Happy to reopen if needed.

@rwjblue rwjblue closed this as completed Sep 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants