From abe2fd065e064d903ae4a2e67b06aea269e13c26 Mon Sep 17 00:00:00 2001 From: ericpsherman Date: Tue, 15 Feb 2022 12:45:08 +0300 Subject: [PATCH] pylint: Enable useless-suppression https://pylint.pycqa.org/en/latest/user_guide/message-control.html#detecting-useless-disables: > As pylint gets better and false positives are removed, disables that became useless can accumulate and clutter the code. In order to clean them you can enable the useless-suppression warning. This doesn't enforce useless-suppression warnings as errors. The idea is cleanup of these warings on every Pylint's bump. Fixes: https://github.com/freeipa/freeipa-healthcheck/issues/244 Signed-off-by: Stanislav Levin --- pylintrc | 12 ++++++++++-- tests/test_ipa_dns.py | 8 ++++---- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/pylintrc b/pylintrc index 08c1307..5439e95 100644 --- a/pylintrc +++ b/pylintrc @@ -28,10 +28,18 @@ valid-metaclass-classmethod-first-arg=cls enable= all, - python3 + python3, + useless-suppression, disable= - I, + bad-inline-option, + c-extension-no-member, + deprecated-pragma, + file-ignored, + locally-disabled, + raw-checker-failed, + suppressed-message, + use-symbolic-message-instead, duplicate-code, interface-not-implemented, no-self-use, diff --git a/tests/test_ipa_dns.py b/tests/test_ipa_dns.py index 636b5a2..8fc267e 100644 --- a/tests/test_ipa_dns.py +++ b/tests/test_ipa_dns.py @@ -96,8 +96,8 @@ def query_uri(hosts): if version.MAJOR < 2 or (version.MAJOR == 2 and version.MINOR == 0): m = message.Message() elif version.MAJOR == 2 and version.MINOR > 0: - m = message.QueryMessage() # pylint: disable=E1101 - m = message.make_response(m) # pylint: disable=E1101 + m = message.QueryMessage() + m = message.make_response(m) rdtype = rdatatype.URI for name in ('_kerberos.', '_kpasswd.'): @@ -158,8 +158,8 @@ def fake_query(qname, rdtype=rdatatype.A, rdclass=rdataclass.IN, count=1, if version.MAJOR < 2 or (version.MAJOR == 2 and version.MINOR == 0): m = message.Message() elif version.MAJOR == 2 and version.MINOR > 0: - m = message.QueryMessage() # pylint: disable=E1101 - m = message.make_response(m) # pylint: disable=E1101 + m = message.QueryMessage() + m = message.make_response(m) if rdtype in (rdatatype.A, rdatatype.AAAA): fqdn = DNSName(qname) fqdn = fqdn.make_absolute()