-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to allow comments in schema files #589
Comments
I think we should turn this on permanently rather than introduce a configuration option, I'm happy to be relaxed about the schemas this plugin accepts in cases like this. Thanks for the info. If you'd like to submit a pull request that sets this feature on for the ObjectMappers we use then please feel free. |
Thanks for adding this! |
This feature is causing build issues in my android library. I upgraded jsonschema2pojo version today from 0.4.21 to 0.4.30 and it wasn't working anymore, so I downgraded until the build would pass again.
Which is caused by the following error :
Note that I'm using gson in this specific project. |
@yomik Are you using the Gradle or Maven plugin? It looks like you have a conflict in the Jackson version that is on the plugin classpath. We require Jackson 2.5.0 or later. |
Add a togglable feature to allow comments in input schema files.
As jsonschema2pojo uses Jackson internally, this can be done by enabling the
JsonParser.Feature.ALLOW_COMMENTS
flag for the appropriate ObjectMapper instances.The text was updated successfully, but these errors were encountered: