Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChannelGroups? #146

Open
fursund opened this issue Dec 28, 2021 · 5 comments · May be fixed by #147
Open

ChannelGroups? #146

fursund opened this issue Dec 28, 2021 · 5 comments · May be fixed by #147
Labels
question Further information is requested

Comments

@fursund
Copy link

fursund commented Dec 28, 2021

How would I read a legacy EXR with layer names as "ChannelGroups" separated by "." in the name? Can't seem to find a way in the code.

@fursund fursund added the question Further information is requested label Dec 28, 2021
@johannesvollmer
Copy link
Owner

Hi! This feature has not been fully implemented yet. The prototype exists, but doesn't work. Currently, you have to analyze the channel names on your own. Maybe I can have another look at the feature in the next days

@johannesvollmer
Copy link
Owner

https://github.com/johannesvollmer/exrs/blob/legacy_layers/src/image/channel_groups.rs

Here is the file with some ideas sketches - maybe it can help you to implement your own grouping algorithm until this library supports it

@fursund
Copy link
Author

fursund commented Jan 3, 2022

Thanks!

@johannesvollmer
Copy link
Owner

johannesvollmer commented Jan 3, 2022

I'm currently working on it and theres good progress, see #147 (note, it also contains a lot of other improvements, not all of those changes would be necessary for grouping the channels)

@johannesvollmer johannesvollmer linked a pull request Jan 3, 2022 that will close this issue
7 tasks
@fursund
Copy link
Author

fursund commented Jan 6, 2022

Nice! Looking forward to see how it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants