Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong page turn animation #1084

Open
kaptem opened this issue Oct 2, 2023 · 1 comment
Open

wrong page turn animation #1084

kaptem opened this issue Oct 2, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@kaptem
Copy link

kaptem commented Oct 2, 2023

Describe the bug
A clear and concise description of what the bug is.
Page animation moves in opposite direction as it should on some books.
To Reproduce
Steps to reproduce the behavior:

  1. Open a book that triggers this behavior
  2. Turning page on some books will have the animation go left instead of right when you are progressing through book. Occurs even after purging styles with Calibre.

Expected behavior
Correct page turn behavior, and if it is to obscure, a way to disable page turn animations.

Version:

  • Foliate version: 3.0.0
  • OS/Distribution and version: Latest Arch
  • Desktop environment: KDE
  • Installation method: AUR
@kaptem kaptem added the bug Something isn't working label Oct 2, 2023
@johnfactotum
Copy link
Owner

The animation direction only follows the direction of the content document, and ignores the page progression direction. This is a limitation of CSS multicol, as there's no way of laying out columns in a different direction from the text. So if the content is RTL or vertical-rl, you should explicitly set dir="rtl" or writing-mode: vertical-rl. If that's missing, currently it will try to set the direction based on the direction of the language of the book, though it doesn't set writing-mode for you for CJK books with RTL page progression.

I guess another option would be to just force the text direction as the same as the page progression direction. And maybe force writing mode for CJK. But it would be best to avoid this, as it would only encourage people to not set the direction correctly for their books.

The ability to disable the animation should be added regardless of whether the animation is correct or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants