Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numerically stable false alarm probability for Lomb Scargle #14

Open
johnh2o2 opened this issue Jun 5, 2022 · 0 comments
Open

Numerically stable false alarm probability for Lomb Scargle #14

johnh2o2 opened this issue Jun 5, 2022 · 0 comments
Labels
enhancement

Comments

@johnh2o2
Copy link
Owner

johnh2o2 commented Jun 5, 2022

Current implementation of fap_baluev is numerically unstable and will return 0 when FAP is small enough. There should be a way to obtain a numerically stable implementation (perhaps using a log(-log(FAP)) transform or something).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johnh2o2