Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

join: Emit an error if the input is not sorted [feature request] #134

Closed
sjackman opened this issue Mar 22, 2017 · 5 comments
Closed

join: Emit an error if the input is not sorted [feature request] #134

sjackman opened this issue Mar 22, 2017 · 5 comments

Comments

@sjackman
Copy link
Contributor

sjackman commented Mar 22, 2017

mlr silently gives the wrong answer if the input is not sorted. An error message would be quite helpful. Alternatively, restart the join as though mlr join -u were specified, if it's possible to rewind the inputs (neither are pipes).

@johnkerl
Copy link
Owner

This is by design, to mimic the system join command.

Probably best thing to do is make -u the default.

@johnkerl
Copy link
Owner

... which I personally would not mind at all. And it wouldn't be backwards incompatible.

@sjackman
Copy link
Contributor Author

sjackman commented Mar 23, 2017

I'm fine with making -u the default. An option the invokes the previous behaviour might be helpful to some.

@johnkerl
Copy link
Owner

OK this done in head; will go out with next release. Thank you!! :)

@sjackman
Copy link
Contributor Author

Thanks again, John!

@johnkerl johnkerl removed the active label Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants