Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code sample contradicts readme #11

Open
andagr opened this issue Jun 11, 2019 · 3 comments
Open

Code sample contradicts readme #11

andagr opened this issue Jun 11, 2019 · 3 comments

Comments

@andagr
Copy link

andagr commented Jun 11, 2019

This seems to contradict the readme:
https://github.com/OWASP/CheatSheetSeries/blob/master/cheatsheets/DotNet_Security_Cheat_Sheet.md#a2-weak-account-management

@johnstaveley
Copy link
Owner

Hi, yes I appreciate this doesn't conform to their advice however making users login every 30 minutes is a royal PITA. The usability/security tradeoff comes in here and I would advocate a bit more usability. So long as ExpireTimeSpan is low then the risk is low. Obviously you might make a different decision for your application.

@andagr
Copy link
Author

andagr commented Jun 11, 2019

It's 60 minutes according to their advise, but I agree it would still be a pain :).

I guess this issue is more about the fact that there is a difference in the readme vs the code sample, namely SlidingExpiration, especially since the readme explicitly states

removing sliding expiration

If the setting in the readme (no sliding expiration, regardless of timeout) is what is recommended then it seems a bit odd that the code sample they are linking to directly contradicts this.

@johnstaveley
Copy link
Owner

I think the advice should be low timeout but with sliding expiration. Or an application that warns you that it is going to timeout and prompts you to extend (like my bank does)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants