Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'+'es are stripped from passwords #194

Closed
ajhodges opened this issue Jul 23, 2018 · 4 comments
Closed

'+'es are stripped from passwords #194

ajhodges opened this issue Jul 23, 2018 · 4 comments
Labels
wontfix This will not be worked on

Comments

@ajhodges
Copy link

I'm using django-environ to read passwords that are generated by AWS (i.e. the SES SMTP credentials, which use an AWS Secret as the password). These passwords can have '+' symbols in them, which are stripped by _cast_urlstr()/unquote_plus().

I think for now my temporary fix is to urlencode the passwords, but I feel like I shouldn't have to do that.

@ntravis
Copy link
Contributor

ntravis commented Jul 30, 2018

It's documented in the README and has been that way since 2016. The maintainer is generally open to PRs if you can account for unsafe characters and provide test cases.

https://github.com/joke2k/django-environ#using-unsafe-characters-in-urls

@ajhodges
Copy link
Author

Actually according to that link, '+' is a safe character and does not need to be encoded, so the library is not functioning as per the documentation.

@pssuils
Copy link

pssuils commented Aug 1, 2018

We just run into the same problem 😬. For the moment we'll need to change our passwords to not contain any + however I 👍 that the passwords could include +.

@sergeyklay
Copy link
Collaborator

@ajhodges Please take a look at this answer #288 (comment)

@sergeyklay sergeyklay added the wontfix This will not be worked on label Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants