Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests not running #88

Open
emeaguiar opened this issue Mar 23, 2017 · 3 comments
Open

Tests not running #88

emeaguiar opened this issue Mar 23, 2017 · 3 comments

Comments

@emeaguiar
Copy link

While trying to run tests npm run test the command fails since "10up" is not an preset that exists, besides, jscs has been deprecated in favor of eslint.

I'll update removing jscs and adding the correct eslint configurations.

@mreinstein
Copy link
Contributor

@emeaguiar do you have the eslint configs? I'm happy to get this fixed/merged.

@jonathantneal
Copy link
Owner

Swapping 10up for dev resolves the issue.

@mreinstein
Copy link
Contributor

@jonathantneal I'm not able to replicate this. updating this part of package.json:

"jscsConfig": {
    "preset": "dev"
  },

I still get an error:

🤡 npm test

> [email protected] test /Users/mikereinstein/Sites/flexibility
> npm run jscs


> [email protected] jscs /Users/mikereinstein/Sites/flexibility
> jscs ./lib/

Preset "dev" does not exist
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] jscs: `jscs ./lib/`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] jscs script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/mikereinstein/.npm/_logs/2018-08-01T15_59_07_636Z-debug.log
npm ERR! Test failed.  See above for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants