Fix extglob patterns matching valid paths and update tests.

[danhper]

Hi,

isGlob was currently matching things like @mypath as a glob, but @mypath being a perfectly
valid path, even with extglob on, I think it shoud not match.
Here is the bash documentation about this.
https://www.gnu.org/software/bash/manual/html_node/Pattern-Matching.html

I updated to match @(my|pattern) as a glob, but not @mypath. I did the same for paths with +.

This is actually causing an issue in chokidar (which relies implicitly on this through glob-parent),
as path/to/@mydir is not treated as it should be.

Also, from should.js 0.7, should.be.true like matchers all became functions so I modified the tests,
otherwise they would become noop as the version of should.js was not locked.

Thanks.

[jonschlinkert]

hmm, I see your point. I think if we add this functionality we should just use: https://github.com/jonschlinkert/is-extglob. It's more comprehensive and has extensive unit tests for extglob features.

would you mind updating the pr to just use is-extglob?

[danhper]

Hi, thanks for the quick reply.
I did not know you made a package for this, but sure it is better to use something well tested!
I just updated the PR.

[jonschlinkert]

great thanks!

[jonschlinkert]

published as patch release 2.0.1 on npm, and tagged as 2.0.1. thanks @tuvistavie!

[danhper]

Great, thanks!