diff --git a/src/Makefile.am b/src/Makefile.am index d2c4d612c..f0a0e5b11 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -132,6 +132,7 @@ BITCOIN_CORE_H = \ clientversion.h \ coins.h \ compat.h \ + compat/assumptions.h \ compat/byteswap.h \ compat/endian.h \ compat/sanity.h \ diff --git a/src/compat/assumptions.h b/src/compat/assumptions.h new file mode 100644 index 000000000..1935f911f --- /dev/null +++ b/src/compat/assumptions.h @@ -0,0 +1,48 @@ +// Copyright (c) 2009-2010 Satoshi Nakamoto +// Copyright (c) 2009-2019 The Bitcoin Core developers +// Distributed under the MIT software license, see the accompanying +// file COPYING or http://www.opensource.org/licenses/mit-license.php. + +// Compile-time verification of assumptions we make. + +#ifndef BITCOIN_COMPAT_ASSUMPTIONS_H +#define BITCOIN_COMPAT_ASSUMPTIONS_H + +#include + +// Assumption: We assume that the macro NDEBUG is not defined. +// Example(s): We use assert(...) extensively with the assumption of it never +// being a noop at runtime. +#if defined(NDEBUG) +#error "Bitcoin cannot be compiled without assertions." +#endif + +// Assumption: We assume the floating-point types to fulfill the requirements of +// IEC 559 (IEEE 754) standard. +// Example(s): Floating-point division by zero in ConnectBlock, +// CreateTransaction +// and EstimateMedianVal. +static_assert(std::numeric_limits::is_iec559, "IEEE 754 float assumed"); +static_assert(std::numeric_limits::is_iec559, + "IEEE 754 double assumed"); + +// Assumption: We assume floating-point widths. +// Example(s): Type punning in serialization code +// (ser_{float,double}_to_uint{32,64}). +static_assert(sizeof(float) == 4, "32-bit float assumed"); +static_assert(sizeof(double) == 8, "64-bit double assumed"); + +// Assumption: We assume integer widths. +// Example(s): GetSizeOfCompactSize and WriteCompactSize in the serialization +// code. +static_assert(sizeof(short) == 2, "16-bit short assumed"); +static_assert(sizeof(int) == 4, "32-bit int assumed"); + +// Some important things we are NOT assuming (non-exhaustive list): +// * We are NOT assuming a specific value for sizeof(std::size_t). +// * We are NOT assuming a specific value for std::endian::native. +// * We are NOT assuming a specific value for std::locale("").name(). +// * We are NOT assuming a specific value for +// std::numeric_limits::is_signed. + +#endif // BITCOIN_COMPAT_ASSUMPTIONS_H diff --git a/src/util.h b/src/util.h index bae0ef989..c291be94d 100644 --- a/src/util.h +++ b/src/util.h @@ -13,6 +13,7 @@ #include #include +#include #include #include #include diff --git a/src/validation.cpp b/src/validation.cpp index 89f672199..683955541 100644 --- a/src/validation.cpp +++ b/src/validation.cpp @@ -53,12 +53,6 @@ #include #include -#include - -#if defined(NDEBUG) -#error "DeVault cannot be compiled without assertions." -#endif - #define MICRO 0.000001 #define MILLI 0.001 /**