Country code not set when first two digits eq country code

[espen]

PhonyRails.normalize_number("47112233", :default_country_code => "NO")
=> "47112233"

Should be 4747112233. The check for adding country code is just 'if not number =~ /^(00|+|#{default_country_number})/'.

[espen]

My first thought is to use Phony plausible. If the country code is set then it should pass plausible. If not then country code can be added. If that is not plausible then return nil.

[joost]

Sounds good :) pull request welcome!

[espen]

Phony.plausible fails with current Phony version as in Gemfile.lock, but using latest Phony it works for the example phone number in this issue. However using plausible breaks 26 other tests, example: floere/phony#143

[espen]

Are all phone numbers in the spec valid?

Phony.plausible?('310101234123')
=> false

[joost]

310101234123 is not a valid dutch number. It should be like '010 1234123' (without country code) or '+31 10 1234123' (with country code).

[espen]

Thanks. I was just checking plausible after adding +31 which failed the test - but normalizing it first would fix that. Due this issue being quite critical for some of my users I had to remove phony_rails and just do some simple number formatting directly with Phony (trying to send SMS with incorrect number is less of a problem than not being able to format a correct number). Currently this is what I am using as code which works for my simple tests. I will try to implement this in phony_rails later:

  def format_phone_number(phone_number)
    default_country_code = Country[self.client.country_code].country_code
    if Phony.plausible?(phone_number)
      phone_number = Phony.normalize(phone_number)
    else
      phone_number = Phony.normalize("+#{default_country_code}#{phone_number}")
      if !Phony.plausible?(phone_number)
        return nil
      end
    end
    return Phony.formatted(phone_number, :format => :international, :spaces => '')
  end