Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phony_normalize strips parentheses from NDC part #89

Closed
brentahiti opened this issue Apr 8, 2015 · 2 comments
Closed

phony_normalize strips parentheses from NDC part #89

brentahiti opened this issue Apr 8, 2015 · 2 comments

Comments

@brentahiti
Copy link

when validating this number '+33 (0)6 87 36 18 75' (French number), which is valid from Phony.plausible?, phony_normalize strips the parentheses here : https://github.com/joost/phony_rails/blob/master/lib/phony_rails.rb#L25.
The resulting number ('+330687361875') isn't plausible anymore
@joost
Copy link
Owner

joost commented Apr 8, 2015

Closed by 5a18f73. Also added tests.

@joost joost closed this as completed Apr 8, 2015
@joost
Copy link
Owner

joost commented Apr 8, 2015

Is in v0.12.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joost @brentahiti