Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overseerr - Requested by user (Plex or local username) using null instead of user name #995

Closed
vitorcsbrito opened this issue Mar 24, 2024 · 3 comments · Fixed by #1070
Closed

Comments

@vitorcsbrito
Copy link

vitorcsbrito commented Mar 24, 2024

Describe the bug
When implementing a rule with the filtering by overseerr user username the firstValue used for comparison is "null" instead of the actual username making the rule always fail

To Reproduce
Steps to reproduce the behavior:

  1. Request movie on overseerr
  2. Implement rule like so:
mediaType: MOVIES
rules:
  - "0":
      - firstValue: Overseerr.addUser
        action: EQUALS
        customValue:
          type: text
          value: <username>
  1. Test rule in collection viewer
  2. Observe that result is false
- plexId: <plexid>
  result: false
  sectionResults:
    - id: 0
      result: false
      ruleResults:
        - operator: OR
          action: equals
          firstValueName: Overseerr - Requested by user (Plex or local username)
          firstValue:
            - null
          secondValueName: text
          secondValue: <username>
          result: false

Expected behavior
Rule should use actual username and provide correct filtering like so:

- plexId: <plexid>
  result: true
  sectionResults:
    - id: 0
      result: true
      ruleResults:
        - operator: OR
          action: equals
          firstValueName: Overseerr - Requested by user (Plex or local username)
          firstValue:
            - <username>
          secondValueName: text
          secondValue: <username>
          result: true

Screenshots
If applicable, add screenshots to help explain your problem.

Device (please complete the following information):

  • TrueNAS Scale (image from truecharts, latest)
  • Version [2.0.2]

Additional context
Add any other context about the problem here.

@RaunoT
Copy link

RaunoT commented Apr 4, 2024

Running into the same issue in 2.0.3

@Manny8787
Copy link

I have the same sort of issue, instead the first value is coming back with my Admin account name.

@jorenn92
Copy link
Owner

jorenn92 commented May 6, 2024

Is this the initial rule in the first section? If so, it seems the issue isn't directly linked to the rule itself but rather to an error during rule creation. The very first rule shouldn't contain an operator, and if it does, it will cause the rule to malfunction.

If this is indeed the scenario, I recommend exporting your rule, removing the operator from the first rule of the first section, and then re-importing the rule. This should resolve the issue.

Edit: i pushed a fix for the above scenario in #1070.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants