Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset Y coordinate using API. #14

Open
RE4ERKA opened this issue Jun 28, 2024 · 1 comment
Open

Offset Y coordinate using API. #14

RE4ERKA opened this issue Jun 28, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@RE4ERKA
Copy link

RE4ERKA commented Jun 28, 2024

My server runs on version 1.20, but I use ViaVersion and ViaBackwards, which often results in players connecting with version 1.16.5. Since it's impossible to go below coordinate 0 in version 1.16.5, players cannot descend into the new caves added in version 1.18.

Your plugin already contains a lot of ready-made code for coordinate shifting, and I would like to solve my problem using your plugin by raising the Y coordinates for players with version 1.16.5 and below (changing -64 to 0) so they can descend into the new caves.

For me, it's not necessarily required that this feature be available as a configuration since it's quite specific and may not fit the main idea of the plugin. Therefore, I would like to be able to shift the Y coordinates as a custom Offset Provider in your API.

I would be grateful if you could help me with my problem.

@RE4ERKA RE4ERKA added the enhancement New feature or request label Jun 28, 2024
@joshuaprince
Copy link
Owner

Packet translation would be the biggest challenge. Adding a vertical offset would be simple for most packet types, but packets like Chunk Data probably can't be shifted like that without some serious rewriting.

Also, pre-1.17 clients have to cut off part of the world somewhere - regardless of which altitudes are present, sending a 384-block-tall world to a 256-block-tall client has to lose some blocks. Sending -64 as 0 would mean the height limit for these players is now 192 (granted, this already happens above 256, but natural terrain does generate above 192). Having offsets change as they move up and down so that they can see the whole world is even more complex.

Frankly, encouraging players to update to 1.17 or above if they want that terrain seems much easier. I might try it at some point to see if it's feasible, but when the only use case is helping players who don't want to update, I prefer the "update if you want new features" philosophy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants