Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'default_bindings' setting not taken into account #9

Open
joerideg opened this issue Jun 11, 2024 · 1 comment · May be fixed by #10
Open

'default_bindings' setting not taken into account #9

joerideg opened this issue Jun 11, 2024 · 1 comment · May be fixed by #10

Comments

@joerideg
Copy link

It seems that setting default_bindings to 'false' has no effect. And I think its this line of code

It seems to me that if the value there is 'false' that statement always resolves to 'true' isnt it? Since you want the default setting to be 'true' we would need to check if the default_bindings is 'nil', not 'falsy'.
joerideg added a commit to joerideg/aider.nvim that referenced this issue Jun 11, 2024
@joerideg
Set default config when settings are nil
1140810 
Fixes joshuavial#9
@joerideg joerideg linked a pull request Jun 11, 2024 that will close this issue
Open
@joerideg
Copy link
Author

My first ever Lua code haha but I thought It was worth a shot. Hope this helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set default config when settings are nil joerideg/aider.nvim
1 participant
@joerideg