Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-API version #53

Closed
MigFerreira opened this issue Oct 11, 2020 · 6 comments · Fixed by #64
Closed

N-API version #53

MigFerreira opened this issue Oct 11, 2020 · 6 comments · Fixed by #64

Comments

@MigFerreira
Copy link

When installing on windows everything is fine, but on mac I get this:
Cannot find module '.../node_modules/@journeyapps/sqlcipher/lib/binding/napi-v3-darwin-x64/node_sqlite3.node'
And I have napi-v6-darwin-x64 in binding folder

In console I get this as well: node-pre-gyp info This Node instance does not support builds for N-API version 6

I even lowered node from 14.x to 12.18.4
Also Ive tried building from source and issue persists

Any advice?

@FTAndy
Copy link

FTAndy commented Nov 5, 2020

same issue

@maitham
Copy link

maitham commented Nov 18, 2020

+1

@Christilut
Copy link

Same problem on Electron 11 here. Any fix for this yet?

@rkistner
Copy link
Member

Working to get a fix out in the next week or so.

@Christilut
Copy link

Actually I upgraded my Node from 12.13 to 12.20 and this error is gone, but now the build fails like in #63

@rkistner
Copy link
Member

The general solution is:

  1. Make sure the correct N-API version of the bindings is installed.
  2. Don't rebuild with electron-forge or electron-rebuild.

For Electron 11+, use Node v10.20.0+ / v12.17.0+ / v14.0.0.
For Electron 10 and earlier, use an earlier Node version.
Note: Just changing the node version is not sufficient - you may need to remove node_modules and install again.

For more details see the new notes: https://github.com/journeyapps/node-sqlcipher/blob/3870217c1245dd4253e2bac2ea8d1d12a8c4a2b6/README.md#usage-with-electron-forge--electron-rebuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants