0.11: Writable stream _write gets called with 'buffer' encoding

[hueniverse]

var stream = require('stream');
var util = require('util');

var Peek = function () {
    stream.Writable.call(this);
};

util.inherits(Peek, stream.Writable);

Peek.prototype._write = function (chunk, encoding, callback) {
    console.log(encoding);
    callback();
};

var preview = new Peek();
preview.write('some text', 'utf-8');
preview.end();
preview.removeAllListeners();

In node 0.10.17:

utf-8

in node 0.11.6:

buffer

[isaacs]

This is working as intended in v0.11. It's actually a Buffer object in both cases. The bug is that v0.10 is passing the encoding along even though it's been buffer-ified.

The intent of this API is so that users don't have to worry about the encoding most of the time. If you want to preserve the strings instead of decoding them into the raw bytes in a buffer, you can do it this way:

var Peek = function (options) {
  options = options || {};
  options.decodeStrings = false;
  stream.Writable.call(this, options);
};

util.inherits(Peek, stream.Writable);

Working on the actual bug now.

[hueniverse]

Thanks.