This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
src: fix backport for SIGINT crash fix on FreeBSD #14819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61fe1fe backported b64983d from io.js, but failed to change nullptr to NULL, which lead to a build break on FreeBSD since the current build system doesn't enable support for C++11. This change replaces nullptr by NULL, and has been tested on FreeBSD 10.1-RELEASE-p8. Fixes nodejs#9326.
|
/cc @joyent/node-coreteam. |
Closed
|
LGTM |
misterdjules
pushed a commit
that referenced
this pull request
Apr 15, 2015
61fe1fe backported b64983d from io.js, but failed to change nullptr to NULL, which lead to a build break on FreeBSD since the current build system doesn't enable support for C++11. This change replaces nullptr by NULL, and has been tested on FreeBSD 10.1-RELEASE-p8. Fixes #9326. Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #14819
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
61fe1fe backported
b64983d from io.js, but failed to
change nullptr to NULL, which lead to a build break on FreeBSD since the
current build system doesn't enable support for C++11.
This change replaces nullptr by NULL, and has been tested on
FreeBSD 10.1-RELEASE-p8.
Fixes #9326.