Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

buffer: reword Buffer.concat error message #8723

Closed
wants to merge 1 commit into from

Conversation

chrisdickinson
Copy link

this brings the error messaging in line with other node TypeError messages.

fixes #7766.

this brings the error messaging in line with
other node TypeError messages.

fixes nodejs#7766.
@cjihrig
Copy link

cjihrig commented Dec 8, 2014

LGTM

@misterdjules
Copy link

👍

@trevnorris
Copy link

@chrisdickinson was this merged?

@trevnorris trevnorris self-assigned this Feb 11, 2015
@misterdjules
Copy link

@trevnorris It hasn't been merged. Technically it could be considered as an API change, but it's very unlikely that anyone relies on this error's message if/when catching it.

@joyent/node-coreteam Is anyone opposed to landing it in v0.12? If not, I'll land it in v0.12 and master, otherwise just in master.

Thank you!

@trevnorris
Copy link

I'm fine landing this on v0.12.

@jasnell
Copy link
Member

jasnell commented Mar 3, 2015

LGTM. Note, #9174 will touch this also.

misterdjules pushed a commit to misterdjules/node that referenced this pull request Mar 3, 2015
this brings the error messaging in line with
other node TypeError messages.

fixes nodejs#7766.

PR: nodejs#8723
PR-URL: nodejs#8723
Reviewed-by: Trevor Norris <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@misterdjules
Copy link

This actually also affects v0.10, so we could land it there first. @joyent/node-coreteam Thoughts?

@cjihrig
Copy link

cjihrig commented Mar 3, 2015

No reason it couldn't go in 0.10. Just not sure if it's worth the time to do so.

@misterdjules
Copy link

@cjihrig Considering there are far more users of v0.10.x than users of v0.12.x, I think it's worth the time to land in v0.10. Especially since it's quick to "backport" to v0.10 and then to merge in v0.12 and master.

@misterdjules misterdjules added this to the 0.10.37 milestone Mar 5, 2015
@misterdjules
Copy link

@joyent/node-coreteam Adding to the 0.10.37 milestone and will land in v0.10 asap as it's not an API change nor a breaking behavior change.

misterdjules pushed a commit to misterdjules/node that referenced this pull request Mar 5, 2015
this brings the error messaging in line with
other node TypeError messages.

fixes nodejs#7766.

PR: nodejs#8723
PR-URL: nodejs#8723
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@misterdjules
Copy link

Landed in d01a900, and merged in v0.12 and master with b0425f0 and a995a6a. Thank you @chrisdickinson!

@piscisaureus
Copy link

@chrisdickinson Are you going to PR this to iojs too?

@cjihrig
Copy link

cjihrig commented Mar 5, 2015

@piscisaureus taken care of.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants