Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SoXR for resampling #22

Open
yoyololicon opened this issue Dec 21, 2023 · 0 comments
Open

Use SoXR for resampling #22

yoyololicon opened this issue Dec 21, 2023 · 0 comments

Comments

@yoyololicon
Copy link

yoyololicon commented Dec 21, 2023

Hi @jpauwels,

Just a suggestion from a Mac Pro M1 user.
The binary libsamplerate.dylib comes with samplerate was built in x86, not ARM.
I did have libsamplerate installed on my Mac, but I don't know why the samplerate couldn't find it, so I have to copy the built binaries into the package directory manually. It works, but it's a bit inconvenient.

On the other hand, soxr is compatible with both x86 and ARM processors. It runs faster than samplerate while having the same resample quality. librosa has dropped resampy as a dependency and moved to soxr. I recommend we follow the same, and it also makes the installation for M1 users a bit easier.

Just some thoughts after spending some time figuring out how to link the library file :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant