Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to use zstd instead of gzip #43

Closed
Jake-Shadle opened this issue Jun 20, 2019 · 5 comments
Closed

Proposal to use zstd instead of gzip #43

Jake-Shadle opened this issue Jun 20, 2019 · 5 comments

Comments

@Jake-Shadle
Copy link
Contributor

Jake-Shadle commented Jun 20, 2019

Before I spent time cleaning up our fork and creating a PR for this, I wanted to check if this is something you would actually be interested in taking back at all.

Basically, I just wanted to use zstd compression instead (or in parallel?) with the current gzip compression. The primary reason is a much lower cache size and overall binary size.

.rw-rw-r--@ 1,422,606 jake 29 May  8:56 embedded-cache.bin.gz
.rw-rw-r--@   967,297 jake 20 Jun  9:22 embedded-cache.bin.zstd

.rwxrwxr-x@  8,034,936 jake 28 May 11:57 askalono
.rwxrwxr-x@  7,130,792 jake 20 Jun  9:22 askalono

There is also a slight (~20ms on my machine) improvement on decompression times, but it's probably not going to be noticeable in practice.

@jpeddicord
Copy link
Owner

Ah! I had almost this exact thought the other day. That would be super cool -- a substantial size reduction and a speedup is a win in my book. Would love to see a PR. :)

@Jake-Shadle
Copy link
Contributor Author

Cool, good to hear, will hopefully have something next week. Do you want it to support both, or just do a straight replacement?

@jpeddicord
Copy link
Owner

Replacement is totally fine; no need for both when the format itself is specific to this tool.

@Jake-Shadle
Copy link
Contributor Author

Awesome, that makes it a lot easier. ☺️

@jpeddicord
Copy link
Owner

Closing based on your PR (thanks again!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants