Rewrite copy

[manidlou]

Started #374.

Fixes #83 and #198.

This implementation uses recursive pattern for copying directories. recursive pattern has shown better performance than Promise (copy-benchmark). If this looks good, then we will apply fs.copyFile() to it.

Any feedback appreciated! 😄

[manidlou]

Aah! I forgot node 4 cannot read new es {} module loading syntax!

[coveralls]

Coverage increased (+0.2%) to 87.576% when pulling d9d0e74 on rewrite-copy into 2599b67 on master.

[RyanZim]

Code LGTM.

Briefly reviewed tests; your test descriptions look like you're testing all the right cases. Did not line-by-line review all the actual test code to ensure the tests actually assert the behavior described.

Would like at least quick review from @jprichardson as well.

[RyanZim]

@manidlou Not sure why this is WIP? We should probably merge this into a develop branch and have a separate PR for fs.copyFile changes.

[manidlou]

@manidlou Not sure why this is WIP?

Yeah, primarily because of fs.copyFile.

We should probably merge this into a develop branch and have a separate PR for fs.copyFile changes.

Good idea! 👍

[jprichardson]

Stellar work @manidlou! Please squash the changes to account for the destructuring fix, and then it LGTM.

[manidlou]

Please squash the changes to account for the destructuring fix, and then it LGTM.

Sure thing.

[coveralls]

Coverage increased (+0.2%) to 87.576% when pulling fe0bfe2 on rewrite-copy into 2599b67 on master.

[manidlou]

Squash done! 😃

[RyanZim]

Will merge when I’m on desktop.

[manidlou]

@RyanZim ping?!

[RyanZim]

Thanks for the ping @manidlou, I totally forgot this. Merged to new develop branch.