Update Commandant

[marcelofabri]

Now that SourceKitten requires Swift 5.0 to build, we can update Carthage/Commandant to the latest version, which drops the Result dependency.

I started doing that, but it broken some unit tests and it wasn't obvious to me what the fix should be.

[jpsim]

We're using the last Commandant version to include an Xcode project, meaning that if we update we can no longer include Commandant as a git submodule without some decent build system changes.

That's also why the unit tests you linked to failed when you upgraded.

[marcelofabri]

Ah I didn't notice that! Thanks for the explanation :)

[ikesyo]

We're using the last Commandant version to include an Xcode project, meaning that if we update we can no longer include Commandant as a git submodule without some decent build system changes.

The latest Commandant 0.17.0 still have its Xcode project, so what does it mean?

[jpsim]

The latest Commandant 0.17.0 still have its Xcode project/workspace, so what does it mean?

🤔 You're absolutely right, I was remembering a PR that was planning on removing it, but clearly that didn't happen. My mistake 😬.

[jpsim]

Fixed in #625.