Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconistent date format when using showMultiDayTimes #918

Closed
eps1lon opened this issue Jul 25, 2018 · 4 comments
Closed

Inconistent date format when using showMultiDayTimes #918

eps1lon opened this issue Jul 25, 2018 · 4 comments
Labels

Comments

@eps1lon
Copy link
Contributor

eps1lon commented Jul 25, 2018

Do you want to request a feature or report a bug?

bug

What's the current behavior?

Format for dates is different for multi day events and non multi day events.
rbc_multiday_localizer_bug

localizer:
BigCalendar.setLocalizer(BigCalendar.momentLocalizer(moment));
dependencies:

[email protected]
[email protected]

What's the expected behavior?

Same format is used.

@jquense
Copy link
Owner

jquense commented Jul 25, 2018

This is intentional, you can change all the event range formates to match if you want them to be the same. Thanks!

@jquense jquense closed this as completed Jul 25, 2018
@eps1lon
Copy link
Contributor Author

eps1lon commented Jul 25, 2018

I don't understand why the default format for multi day events does not match the default format for single day events. I get that I'm able to change the format but why do I provide a localizer if that localizer is not used by default?

Maybe I didn't make myself clear: The issue is not about the format of the range but the format of the time which should be formatted equally regardless of multi day event or not.

@jquense
Copy link
Owner

jquense commented Jul 25, 2018

O! I see what you're saying, yes that seems to be a bug with the moment localizer.

@jquense jquense reopened this Jul 25, 2018
@jquense jquense added the bug label Jul 25, 2018
@eps1lon
Copy link
Contributor Author

eps1lon commented Jul 25, 2018

Thanks. I understand why this could be misinterpreted.

I would just go ahead and claim this and work on a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants