Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official release #3

Open
borissmidt opened this issue Jan 27, 2022 · 12 comments
Open

Official release #3

borissmidt opened this issue Jan 27, 2022 · 12 comments

Comments

@borissmidt
Copy link

Could you officially release your fork as a plugin for firefox and chrome so people can use it without building it themself?

@jrapoport
Copy link
Owner

Yeah, it's been long enough. I'll look into this.

@borissmidt
Copy link
Author

Is there any way i can help with this?

@jrapoport
Copy link
Owner

Not sure. I've never released an extension before. Was planning on digging in this weekend. Hopefully I can just post it and submit a link.

Separately I'm wondering if we need to change the name to avoid confusion?

@borissmidt
Copy link
Author

borissmidt commented Feb 11, 2022

Btw after some reverse engineering with the original plugin i found out that i could do just push custom messages which is handy if you use the improbable-eng backend (it supports websockets).

But it seems that it doesn't work with big responses any idea how it could be fixed?
SafetyCulture/grpc-web-devtools#116

also it might be good to add it to the readme to make it easy for people to add support to other backends.

@stepan-romankov
Copy link

@jrapoport do you still have a plan to maintain this repo?

@jrapoport
Copy link
Owner

Yes. I've been busy working on a number of things and was planning to get caught up this week. For this repo there are a few open things I want to look at, including publishing the plugin to the Chrome. I'm not sure whether changing the name is more or less confusing wrt to the other repo. Any thoughts would be appreciated.

@stepan-romankov
Copy link

Yes. I've been busy working on a number of things and was planning to get caught up this week. For this repo there are a few open things I want to look at, including publishing the plugin to the Chrome. I'm not sure whether changing the name is more or less confusing wrt to the other repo. Any thoughts would be appreciated.

Hi, thanks for reply, I'm asking cause we made a pull request and will be happy to see it in the release
#7

@eeston
Copy link

eeston commented May 3, 2022

@jrapoport I would really appreciate a FF release too! 👍

@jrapoport
Copy link
Owner

Hey guys, believe it or not I have been just completely slammed. But this is something I have been meaning to circle back on forever.

I know there are some pending issues, but-- I'm gonna ignore them for now and focus on getting this out as an official release.

Once that's done, I can start to work through some of the open issues.

I know this has been forever and a lot of you've been waiting for a really long time, but I'm committed to do it this week.

@jrapoport
Copy link
Owner

I just checked on the main repo though it looks like they did a release in 2023 that added some form of interceptor support.

Is this fork actually still useful? I did a complete rewrite of all of their internal code (which frankly I think is a lot more solid than what they had the last time I looked). But if you guys think that releasing/maintaining this isn't worth it after-all, let me know.

@VinceBT-BG
Copy link

Did you manage to make any of the GRPC chrome extensions work with their update ?

@jrapoport
Copy link
Owner

No, but I forked this originally to add / fix native interceptor support.

It looks like they may have revived the project and added that in 2023.

Or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants