Skip to content

Commit

Permalink
Pass correct args when creating event permalink in context menu
Browse files Browse the repository at this point in the history
After the permalink API was changed in
matrix-org#2671, it seems we forgot to
update this call site, so it was creating `<room>/<room>` links, instead of
`<room>/<event>`.

Fixes element-hq/element-web#9110
  • Loading branch information
jryans committed Mar 11, 2019
1 parent 8940c4e commit c38a7e6
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/components/views/context_menus/MessageContextMenu.js
Original file line number Diff line number Diff line change
Expand Up @@ -307,10 +307,7 @@ module.exports = React.createClass({

let permalink;
if (this.props.permalinkCreator) {
permalink = this.props.permalinkCreator.forEvent(
this.props.mxEvent.getRoomId(),
this.props.mxEvent.getId(),
);
permalink = this.props.permalinkCreator.forEvent(this.props.mxEvent.getId());
}
// XXX: if we use room ID, we should also include a server where the event can be found (other than in the domain of the event ID)
const permalinkButton = (
Expand Down

0 comments on commit c38a7e6

Please sign in to comment.