Enable special characters in UI5 control ids #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dominikfeininger
commented
Mar 2, 2022
dominikfeininger
commented
- change wdio selector from id to xpath
- basic check for selector structure
vobu
requested changes
Mar 2, 2022
| id: 'Title::NoAction.h1', | ||
| viewName: "test.Sample.view.Main" | ||
| } | ||
| }; |
There was a problem hiding this comment.
please apply prettier formatting on the file :)
| expect(titleWwdio).toEqual('UI5 demo'); | ||
| }); | ||
|
|
||
| it.only('check for invalid control selector', async () => { |
src/lib/wdi5-bridge.ts
Outdated
| @@ -142,6 +142,20 @@ function _createWdioUI5KeyFromSelector(selector: wdi5Selector): string { | |||
|
|
|||
| export async function addWdi5Commands() { | |||
| browser.addCommand("_asControl", async (wdi5Selector: wdi5Selector) => { | |||
| if ( | |||
There was a problem hiding this comment.
i suggest to outsource this in a separate function.
- there will be more conditional checks in the future (e.g.
controlType&&viewNameOR onlyid) - we should be more specific with the error, e.g.
selector is missing the "selector" object
dominikfeininger
changed the title
vobu
requested changes
Mar 4, 2022
src/lib/wdi5-bridge.ts
Outdated
| @@ -12,6 +12,7 @@ import { clientSide__navTo } from "../../client-side-js/_navTo" | |||
|
|
|||
| import { Logger as _Logger } from "./Logger" | |||
| const Logger = _Logger.getInstance() | |||
| // test | |||
src/lib/wdi5-bridge.ts
Outdated
| * @param wdi5ControlSelector | ||
| * @returns {Boolean} if the givven selector is a valid selector | ||
| */ | ||
| function _verifySelector(wdi5ControlSelector) { |
There was a problem hiding this comment.
please add the type here: wdi5ControlSelector: wdi5Selector
vobu
reviewed
Mar 4, 2022
src/lib/wdi5-bridge.ts
Outdated
| /** | ||
| * does a basic validation of a wdi5ControlSelector | ||
| * @param wdi5ControlSelector | ||
| * @returns {Boolean} if the givven selector is a valid selector |
There was a problem hiding this comment.
typo "givven"
type "Boolean" -> "boolean"
vobu
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.