Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combobox special case #191

Merged
merged 7 commits into from
Mar 25, 2022
Merged

combobox special case #191

merged 7 commits into from
Mar 25, 2022

Conversation

dominikfeininger
Copy link
Collaborator

@dominikfeininger dominikfeininger changed the title combobox special case WIP: combobox special case Mar 18, 2022
@vobu vobu mentioned this pull request Mar 20, 2022
Merged
vobu
vobu requested changes Mar 20, 2022
View reviewed changes
Copy link
Contributor

@vobu vobu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall this is a cool sustainable solution as it provides us with an easy "extension" mechanism for further special handling of certain control types.
some review comments and:
please move all sap.m.ComboBox-centric tests to a dedicated test file!

src/lib/wdi5-control.ts Outdated Show resolved Hide resolved
src/lib/wdi5-control.ts Outdated Show resolved Hide resolved
src/lib/wdi5-control.ts Outdated Show resolved Hide resolved
client-side-js/injectUI5.js Show resolved Hide resolved
examples/ui5-js-app/webapp/test/e2e/basic.test.js Outdated Show resolved Hide resolved
examples/ui5-js-app/webapp/test/e2e/basic.test.js Outdated Show resolved Hide resolved
examples/ui5-js-app/webapp/test/e2e/basic.test.js Outdated Show resolved Hide resolved
examples/ui5-js-app/webapp/test/e2e/basic.test.js Outdated Show resolved Hide resolved
examples/ui5-js-app/webapp/test/e2e/basic.test.js Outdated Show resolved Hide resolved
@dominikfeininger dominikfeininger changed the title WIP: combobox special case combobox special case Mar 20, 2022
@vobu vobu merged commit c2984bd into main Mar 25, 2022
@vobu vobu deleted the feature/121 branch March 25, 2022 08:00
@dominikfeininger dominikfeininger mentioned this pull request May 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vobu vobu vobu approved these changes

@Siolto Siolto Awaiting requested review from Siolto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominikfeininger @vobu