Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Select not changing when i change value manually without the onSelect #126

Open
omar-bear opened this issue Sep 22, 2021 · 0 comments
Open

Comments

@omar-bear
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-magnus/src/ui/select/select.component.tsx b/node_modules/react-native-magnus/src/ui/select/select.component.tsx
index 3f0e3e5..939ba08 100644
--- a/node_modules/react-native-magnus/src/ui/select/select.component.tsx
+++ b/node_modules/react-native-magnus/src/ui/select/select.component.tsx
@@ -54,6 +54,10 @@ const Select = React.forwardRef<SelectRef, SelectProps>(
       searchableProps,
     ]);
 
+    useEffect(() => {
+      setSelectedValue(value)
+    }, [value])
+
     const computedStyle = getStyle(theme, props);
 
     const resolveMultiLevelAccess = (obj: any, key: string) => {

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant