Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Importing plugins with relative paths at travis #759

Closed
qfox opened this issue Nov 10, 2014 · 5 comments
Closed

Importing plugins with relative paths at travis #759

qfox opened this issue Nov 10, 2014 · 5 comments
Labels

Comments

@qfox
Copy link
Member

qfox commented Nov 10, 2014

According to #731

It doesn't work for relative paths at travis ;-(
Tests: https://travis-ci.org/jscs-dev/jscs-jsdoc/jobs/40507024
Code: https://github.com/zxqfox/jscs-jsdoc/tree/feature/pluginization

plugin/
  index.js
  test/
    test.js

test.js:

checker.configure({
  plugins: ['.']
});

basePath at dev machine is plugin and there are no troubles.
But at travis it couldn't find '.' module so it looks like basePath is different.

@mdevils
Copy link
Member

mdevils commented Nov 18, 2014

Take a look: jscs-dev/jscs-jsdoc#55

@qfox
Copy link
Member Author

qfox commented Nov 19, 2014

@mdevils Thanks! What you think about passing './lib/index' as plugin path? Do you like to do it this way?

@mdevils
Copy link
Member

mdevils commented Nov 19, 2014

It's OK for testing your plugin. Users will not have problems with your plugin, they will be fine with just plugin name.

@qfox
Copy link
Member Author

qfox commented Nov 19, 2014

@mdevils Well, okay. Let it be like that. But better to make a note in Plugin writing guide about testing.

Thanks! I'll merge this soon.

@qfox qfox closed this as completed Nov 19, 2014
@qfox
Copy link
Member Author

qfox commented Nov 19, 2014

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants