Skip to content

Commit

Permalink
Fix a URL code-unit check when parsing opaque paths
Browse files Browse the repository at this point in the history
  • Loading branch information
karwa committed Sep 26, 2023
1 parent ff5c725 commit 569c975
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions lib/url-state-machine.js
Original file line number Diff line number Diff line change
Expand Up @@ -1039,10 +1039,7 @@ URLStateMachine.prototype["parse opaque path"] = function parseOpaquePath(c) {
this.url.fragment = "";
this.state = "fragment";
} else {
// TODO: Add: not a URL code point
if (!isNaN(c) && c !== p("%")) {
this.validationErrors.push("invalid-URL-unit");
}
// TODO: If c is not the EOF code point, not a URL code point, and not U+0025 (%), invalid-URL-unit validation error.

Check failure on line 1042 in lib/url-state-machine.js

View workflow job for this annotation

GitHub Actions / Lint and tests (16)

This line has a length of 121. Maximum allowed is 120

Check failure on line 1042 in lib/url-state-machine.js

View workflow job for this annotation

GitHub Actions / Lint and tests (18)

This line has a length of 121. Maximum allowed is 120

Check failure on line 1042 in lib/url-state-machine.js

View workflow job for this annotation

GitHub Actions / Lint and tests (20)

This line has a length of 121. Maximum allowed is 120

if (c === p("%") &&
(!infra.isASCIIHex(this.input[this.pointer + 1]) ||
Expand Down

0 comments on commit 569c975

Please sign in to comment.