Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yielding the hdrhistogram crate name #1

Closed
jonhoo opened this issue Jan 11, 2018 · 7 comments
Closed

Yielding the hdrhistogram crate name #1

jonhoo opened this issue Jan 11, 2018 · 7 comments

Comments

@jonhoo
Copy link

jonhoo commented Jan 11, 2018

I'm the maintainer of the hdrsample crate, a pure-Rust implementation of HdrHistogram. It's pretty close to feature complete now, and Gil Tene (@giltene; the original HdrHistogram author) wants to move it into the official HdrHistogram GitHub organization (HdrHistogram/HdrHistogram_rust#60).

When doing so, we'd also like to rename the crate to hdrhistogram to maintain consistency with the various other HdrHistogram implementations. However, that name is already taken by this crate. Given that it seems to no longer be maintained, we've been wondering whether we could convince you to give up the hdrhistogram crate name so we could replace it with the now-official Rust crate?

If you decide that's okay, you unfortunately can't currently delete or rename crates on crates.io (rust-lang/crates.io#166), but we should be able to just replace the crate in-place with the Rust version if you add me using cargo owner: http://doc.crates.io/crates-io.html#cargo-owner

Let me know what you think!
Cheers,
Jon

@jsgf
Copy link
Owner

jsgf commented Jan 14, 2018

Hi - I have no problem w this in principle. Let me look at the details.

@jsgf
Copy link
Owner

jsgf commented Jan 17, 2018

OK, so it looks like this hdrhistogram has a non-zero number of users, so it should still be available. I think we rename the crate to hdrhistogram_c in crates.io and put a note in the README for the Rust hdrhistogram so they can easily update their Cargo.toml.

@jonhoo
Copy link
Author

jonhoo commented Jan 17, 2018

Huh interesting... Those may just be bot downloads. But yes, we should be on the safe side, so that seems like a reasonable course of action! The way to go about it would then likely be:

  1. You upload your crate to crates.io as hdrhistogram_c
  2. I push a change to my crate's README to point people to hdrhistogram_c
  3. You give me owner access to crates.io/hdrhistogram
  4. I publish the current version of my crate to crates.io/hdrhistogram (should work fine as mine has a higher version number than yours)
  5. I push a new minor version of hdrsample where the main types are all deprecated, and where the docs say to use hdrhistogram instead.

How does that sound?

/cc @marshallpierce

@jonhoo
Copy link
Author

jonhoo commented Jan 21, 2018

@jsgf ping just to keep this on your radar.

@jonhoo
Copy link
Author

jonhoo commented Jan 30, 2018

@jsgf still okay with going ahead with this?

@jsgf
Copy link
Owner

jsgf commented Feb 14, 2018

I'm doing the update at the moment. I guess you won't be able to recycle any of the old version numbers, so if you start at >=0.2 then existing users with Cargo.lock files will build unmodified, but new users will need to switch to hdrhistogram_c to continue using the API; otherwise they can convert to the hdrhistogram API.

@jonhoo
Copy link
Author

jonhoo commented Feb 15, 2018

Yup, the intention was to continue hdrsample's versioning, which is currently at 6.0.1. I'll start the migration from my end, including adding a link to hdrhistogram_c. Thanks!

@jsgf jsgf closed this as completed Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants