Making sure also public keys kan be retrieved without relying upon PublicKeyRingBundle #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 2, 2020 22:02
To avoid relying upon `PublicKeyRingBundle` if more generic solution for key lookups is needed
That is the commonalities required to use PGP cryptography, without relying upon GnuPG or local files in any ways, allowing the user to persist his private and public keys as he see fit.
|
Jo mate, I took the liberty of doing what I proposed, to create an interception class between |
|
BTW, not sure why the |
|
Darn it! Thank you for CI ...!! :/ On its way, finally I think ... :) |
|
The TestAutoKeyRetrieve() test fails intermittently due to the fact that Werner's GnuPG key, depending on which keyserver is in the rotation, is sometimes signed with an Elliptic Curve key which is not yet supported by BouncyCastle. I would not worry about it failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This too method needs to be public and virtual, in order for me to retrieve public keys, without relying upon
PublicKeyRingBundle, which makes no sense, if user wants to store (millions potentially) of keys in database.