Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get_or_404 calls #29

Open
glezos opened this issue Jan 21, 2010 · 0 comments
Open

Remove get_or_404 calls #29

glezos opened this issue Jan 21, 2010 · 0 comments

Comments

@glezos
Copy link

glezos commented Jan 21, 2010

I suppose most of the users are treating django-notification as a library instead of a front-end, and its views/methods aren't really exposed to the user directly. There are calls of get_or_404 in the code which, if a notice type doesn't exist, triggers a 404 error. If the user (and developer) are showing a particular object (which does exist), and django-notification throws a 404 error for its own (valid) reasons, then this is confusing, and not easy to handle.

Bottom line: we should be throwing a NoticeTypeDoesNotExist exception or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant