Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rawBody on empty request.body #127

Closed
jthegedus opened this issue Sep 8, 2021 · 1 comment · Fixed by #143
Closed

fix: rawBody on empty request.body #127

jthegedus opened this issue Sep 8, 2021 · 1 comment · Fixed by #143
Assignees
@jthegedus
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@jthegedus
Copy link
Owner

Currently sends empty Uint8Array, but should probably send undefined|null as per the discussion in sveltejs/kit#2295
@jthegedus jthegedus self-assigned this Sep 8, 2021
@jthegedus jthegedus added the bug Something isn't working label Sep 8, 2021
@jthegedus jthegedus added the help wanted Extra attention is needed label Sep 16, 2021
@jthegedus
Copy link
Owner Author

Base types in Kit were updated in https://github.com/sveltejs/kit/pull/2299/files#diff-418712fdcdc80e8bf5cc0e519480d6bc0178a372c82aa3675dddd4870a5988a6R25

@jthegedus jthegedus mentioned this issue Sep 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jthegedus jthegedus

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pass null if no req.rawBody jthegedus/svelte-adapter-firebase
1 participant
@jthegedus