Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: output Firebase Hosting deployment command on Cloud Run output suggestion #30

Closed
jthegedus opened this issue Mar 23, 2021 · 1 comment · Fixed by #67
Closed

fix: output Firebase Hosting deployment command on Cloud Run output suggestion #30

jthegedus opened this issue Mar 23, 2021 · 1 comment · Fixed by #67
Assignees
@jthegedus
Labels
bug Something isn't working released

Comments

@jthegedus
Copy link
Owner

jthegedus commented Mar 23, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

Cloud Run deploy command output makes no mention of requiring a firebase deploy --only hosting alongside it.

Describe the solution you'd like

Compute the minimum Firebase deployment command to output to the screen, with hostingSite support.

Describe alternatives you've considered

Additional context
@jthegedus jthegedus added the enhancement New feature or request label Mar 23, 2021
@jthegedus jthegedus self-assigned this Mar 23, 2021
@jthegedus jthegedus added bug Something isn't working and removed enhancement New feature or request labels Mar 23, 2021
@jthegedus jthegedus changed the title fix: output Firebase deployment command on Cloud Run output suggestion fix: output Firebase Hosting deployment command on Cloud Run output suggestion May 10, 2021
@jthegedus jthegedus mentioned this issue May 13, 2021
Merged
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 0.7.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jthegedus jthegedus

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: instruct firebase deployment alongside Cloud Run jthegedus/svelte-adapter-firebase
1 participant
@jthegedus