From ff6a8a0ad8947e68953aed14fc6c12c0abd7ee33 Mon Sep 17 00:00:00 2001 From: jthegedus Date: Thu, 13 May 2021 20:29:21 +1000 Subject: [PATCH 1/2] fix: instruct firebase deployment alongside Cloud Run --- src/index.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/index.js b/src/index.js index 3c2d0cf..dc070a3 100644 --- a/src/index.js +++ b/src/index.js @@ -141,10 +141,12 @@ async function adaptToCloudRun({utils, serviceId, region, firebaseJsonDir, cloud utils.log.warn( // eslint-disable-next-line indent -`To deploy your Cloud Run service, run this command: +`To deploy your Cloud Run service, run both of these commands: +--------------------------------------------------+ gcloud beta run deploy ${serviceId} --platform managed --region ${region} --source ${serverOutputDir} --allow-unauthenticated -+--------------------------------------------------+` +firebase deploy --only hosting ++--------------------------------------------------+ +Firebase deployment is required as your static assets may have new hashes after the build you deploy with Cloud Run` ); } From b767ca450621b2141a6c37cbdd4207762ed0d480 Mon Sep 17 00:00:00 2001 From: jthegedus Date: Thu, 13 May 2021 20:31:52 +1000 Subject: [PATCH 2/2] fix: improve output --- src/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/index.js b/src/index.js index dc070a3..fed4271 100644 --- a/src/index.js +++ b/src/index.js @@ -146,7 +146,7 @@ async function adaptToCloudRun({utils, serviceId, region, firebaseJsonDir, cloud gcloud beta run deploy ${serviceId} --platform managed --region ${region} --source ${serverOutputDir} --allow-unauthenticated firebase deploy --only hosting +--------------------------------------------------+ -Firebase deployment is required as your static assets may have new hashes after the build you deploy with Cloud Run` +Firebase deployment is required as your static assets and route manifests may have changed from this build.` ); }