Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom detection points are not looked up for possible responses #195

Open
si076 opened this issue Jun 26, 2023 · 1 comment
Open

Custom detection points are not looked up for possible responses #195

si076 opened this issue Jun 26, 2023 · 1 comment

Comments

@si076
Copy link

si076 commented Jun 26, 2023

org.owasp.appsensor.analysis.ReferenceAttackAnalysisEngine's method findPossibleResponses doesn't look up also custom detection points for possible responses.
Is this an intended behaviour or it is a bug?

I have almost ported the code to Javascript.
In one of my tests, I configured custom detection poin and generate events of it.
org.owasp.appsensor.analysis.ReferenceEventAnalysisEngine in analyze method takes advantage of org.owasp.appsensor.core.configuration.server.ServerConfiguration's findDetectionPoints method which looks up custom detection poins as well.
When an attack of this detection point is analyzed by org.owasp.appsensor.analysis.ReferenceAttackAnalysisEngine, it doesn't
find possible response and corresponding generated response's action is empty.

Thank you very much for your great code.

Kind regards,
Spas Iliev

@si076
Copy link
Author

si076 commented Jun 27, 2023

Hello,

I see #35 and the reason behind to override some aspects of detection points.
I used to think of client/custom detection points as an extension (e.g. Z01) to the points described in the reference of AppSensor Guide v. 2.0.

I think in both cases the question still stands: Why not to override the response as well?

Kind regards,
Spas Iliev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant