Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building fail on github actions using cmake 3.30 #863

Closed
dr3mro opened this issue Jul 10, 2024 · 7 comments
Closed

building fail on github actions using cmake 3.30 #863

dr3mro opened this issue Jul 10, 2024 · 7 comments

Comments

@dr3mro
Copy link

dr3mro commented Jul 10, 2024

Unknown CMake command "cmake_determine_compile_features".
thats all, looks like cmake has changed a method name
https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9366

please fix

@dr3mro dr3mro changed the title building fail on github actions using cmake 3.3 building fail on github actions using cmake 3.30 Jul 10, 2024
@tt4g
Copy link
Contributor

tt4g commented Jul 11, 2024

Thank you for reporting, this problem already fixed #851 but not release yet).
Workaround use fixed source (fixed in d5bf7cf).

@jtv
Copy link
Owner

jtv commented Jul 20, 2024

@dr3mro does the latest master fix it?

@jlnr
Copy link

jlnr commented Jul 29, 2024

libpqxx 7.9.1 stopped compiling for me with the same error after both Homebrew and my Linux distro upgraded CMake to version 3.30. I can confirm that it is fixed on the latest master commit.

An official release that contains the fix would be greatly appreciated, because then package managers like Conan will pick it up.

% git checkout tags/7.9.1
% cmake ..                
CMake Error at cmake/config.cmake:14 (include):
  include could not find requested file:

    CMakeDetermineCompileFeatures
Call Stack (most recent call first):
  CMakeLists.txt:27 (include)


-- Found PostgreSQL: /opt/homebrew/lib/postgresql@14/libpq.dylib (found version "14.12")
-- Looking for poll
-- Looking for poll - found
CMake Error at cmake/config.cmake:42 (cmake_determine_compile_features):
  Unknown CMake command "cmake_determine_compile_features".
Call Stack (most recent call first):
  CMakeLists.txt:27 (include)


-- Configuring incomplete, errors occurred!


% git checkout master     
Previous HEAD position was c154460e Disable clang-based parsing in Doxygen. (#847)
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
% cmake ..               
-- Generating config.h
-- Generating config.h - done
-- Configuring done (2.9s)
-- Generating done (0.0s)
-- Build files have been written to: [redacted]/build

@jtv
Copy link
Owner

jtv commented Aug 1, 2024

OK, coming up!

@jtv
Copy link
Owner

jtv commented Aug 15, 2024

@jlnr did the release solve your problem?

@dr3mro
Copy link
Author

dr3mro commented Aug 15, 2024

@jlnr did the release solve your problem?

yeah

@jtv
Copy link
Owner

jtv commented Aug 15, 2024

Okay, when we can close this ticket.

@jtv jtv closed this as completed Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants