Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to configure evm_version #444

Open
zhiqiangxu opened this issue Feb 5, 2024 · 4 comments
Open

add support to configure evm_version #444

zhiqiangxu opened this issue Feb 5, 2024 · 4 comments

Comments

@zhiqiangxu
Copy link

zhiqiangxu commented Feb 5, 2024

Foundry can compile successfully but vscode is prompting: Undeclared identifier. Did you mean "blockhash"?(7576):

image

This error is the same error I get from foundry if evm_version is not configured here.

Currently there's no way to configure evm_version for a foundry project:

{
    "solidity.formatter": "forge",
    "solidity.defaultCompiler": "localNodeModule"
}

It would be great if vscode-solidity can read foundry.toml automatically.

Here's the repo that's trigering this issue:

https://github.com/zhiqiangxu/es-op-batchinbox

@zhiqiangxu zhiqiangxu changed the title vscode-solidity is not handling evm_version correctly add support to configure evm_version for vscode-solidity Feb 5, 2024
@zhiqiangxu zhiqiangxu changed the title add support to configure evm_version for vscode-solidity add support to configure evm_version Feb 5, 2024
@juanfranblanco
Copy link
Owner

Added an option on settings now, yes importing from foundry.toml will be ideal

@juanfranblanco
Copy link
Owner

@zhiqiangxu it is out now

@zhiqiangxu
Copy link
Author

@juanfranblanco It works great! Is there a plan to import from foundry.toml ?

@juanfranblanco
Copy link
Owner

Yes there is, as the settings import directly, hopefully I get some time to do it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants