Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include spamassassin #61

Closed
hos-ftv opened this issue Mar 15, 2019 · 9 comments
Closed

Include spamassassin #61

hos-ftv opened this issue Mar 15, 2019 · 9 comments

Comments

@hos-ftv
Copy link
Contributor

hos-ftv commented Mar 15, 2019

Hi there,

would it be possible to include spamassassin? There is a setting (i didn't know of) in Core::Email::PostMaster which we like to use.
So if you agree that this would be a benefit to this project I would create a pull request.

Kind Regards

@juanluisbaptiste
Copy link
Owner

Hi,

Not for now, but you could add a spamassasin container to the docker-compose.yml file and configure OTRS to use it, I think that shuld be it.

@hos-ftv
Copy link
Contributor Author

hos-ftv commented Mar 18, 2019

Alright. I'm fine with an external solution.

@hos-ftv hos-ftv closed this as completed Mar 18, 2019
@juanluisbaptiste
Copy link
Owner

@hos-ftv at the end did you work on this ?

@hos-ftv
Copy link
Contributor Author

hos-ftv commented May 29, 2019

Nope. For us it was a little bit of overhead to setup an additional image just for spamassassin and to deal with the accessibility and configuration via OTRS. Maybe if we would have used it for other services/environments an extraction would make sense (for us).
We stick to our build-in - solution and use a forked version of docker-otrs. It's quite straight-forward to just add spamassassin.

Anyway. I'm totally fine with your point of view to keep this project-repo clean and to provide additional services via additional containers.

@juanluisbaptiste
Copy link
Owner

Could you share what you did anyway ? it would help me on integrating an external container, I have no experience with spamassassin.

Thanks.

@hos-ftv
Copy link
Contributor Author

hos-ftv commented May 31, 2019

If you ship this with the docker-otrs there is not much to be done. Just install spamassassin und activate the default setting in Core::Email::PostMaster::PreFilterModule###6-SpamAssassin.

I've prepared a simple example-branch based on your current HEAD for a slight simpler comparison. Hope this will help:
master...FutureTVGroup:examples/spamassassin

@fajfer
Copy link
Contributor

fajfer commented Dec 20, 2020

@juanluisbaptiste I've got it working with spamassassin, if implemented correctly, would it be a feature you would consider merging into the master?

@juanluisbaptiste
Copy link
Owner

If your implementation adds spamassasin to this container then no, spamassasin should run on it's own container and on OTRS there should be only the code and env vars to enable this feature.

@fajfer
Copy link
Contributor

fajfer commented Jan 6, 2021

If your implementation adds spamassasin to this container then no, spamassasin should run on it's own container and on OTRS there should be only the code and env vars to enable this feature.

I have it separately and I agree with you. I was supposed to tidy it up a bit for myself so once I'm done I'll surely try with a pull request here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants