Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last Login IP Not working correctly #17

Open
J12934 opened this issue Aug 11, 2019 · 5 comments
Open

Last Login IP Not working correctly #17

J12934 opened this issue Aug 11, 2019 · 5 comments
Labels
incompatible challenge Challenges which work in JuiceShop but not in MultiJuicer

Comments

@J12934
Copy link
Member

J12934 commented Aug 11, 2019

The last login ip will show the ip of the LoadBalancer not the IP of the User... 😳

Warning Spoilers:

The challenge to override the Last Login IP will most likely also not work in most cloud setups as the initial Cloud Loadbalancer will most likely strip away the X-Forwarded-For headers set by the user.

@J12934 J12934 added the incompatible challenge Challenges which work in JuiceShop but not in MultiJuicer label Aug 11, 2019
@bkimminich
Copy link
Member

Should we just turn this challenge off on Docker/Heroku like the dangerous ones?

@J12934
Copy link
Member Author

J12934 commented Nov 11, 2019

Mh yeah that might be an option.
But it should probably work correctly on "normal" docker setups right, meaning setups without a loadbalancer in front of it.

@bkimminich
Copy link
Member

True ... do you know any way to determine that a load balancer is in front of you...? 🔮

@J12934
Copy link
Member Author

J12934 commented Nov 11, 2019

Well they normally set X-Forwareded-For headers 🤷‍♂️
But that would break the challenge 🤦‍♂️

@bkimminich
Copy link
Member

Just checked the code of the challenge, and it doesn't use XFF for that matter but the True-Client-IP header. So it should work just fine even behind a load balancer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible challenge Challenges which work in JuiceShop but not in MultiJuicer
Projects
None yet
Development

No branches or pull requests

2 participants